Skip to content

Move initialization into doInitialize and report progress#74

Merged
fwcd merged 4 commits intomainfrom
initialize-handling
Oct 14, 2024
Merged

Move initialization into doInitialize and report progress#74
fwcd merged 4 commits intomainfrom
initialize-handling

Conversation

@fwcd
Copy link
Copy Markdown
Owner

@fwcd fwcd commented Oct 14, 2024

Supersedes #24

Performing our initialization (indexing and compiling all modules) before responding to the initialize request, instead of in the initialized notification, seems to be a cleaner way of handling required initialization, since language features like go-to-definition will be fully disabled instead of hanging. Additionally, the client can provide us with a progress token to report progress with.

Since we cannot report diagnostics before responding to initialize, we leave that in the initialized notification handler.

@fwcd fwcd merged commit a0b361e into main Oct 14, 2024
@fwcd fwcd deleted the initialize-handling branch October 14, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant